Allow environment variables and extra args to be passed to pip.#101
Closed
Globegitter wants to merge 1 commit intobazel-contrib:masterfrom
Closed
Allow environment variables and extra args to be passed to pip.#101Globegitter wants to merge 1 commit intobazel-contrib:masterfrom
Globegitter wants to merge 1 commit intobazel-contrib:masterfrom
Conversation
stefanhdao
reviewed
Dec 10, 2018
|
|
||
| def main(): | ||
| args = parser.parse_args() | ||
| args, unkwown = parser.parse_known_args() |
|
Any progress here? Would love to see this committed to the repo. Thanks. |
|
I would also like to see this committed as well. |
|
bump |
1 similar comment
|
bump |
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
bot
added
the
Can Close?
|
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
|
Any update? |
|
@xhuoroku look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #74 but was really motivated by the fact that I wanted to install https://github.com/uploadcare/pillow-simd with the
cc -mavx2option reliably. So I needed the option to pass in environment variables that get propagated to pip and I further ran into this issue: uploadcare/pillow-simd#26 so also needed to be able to pass in custom arguments.So an example would be: